Skip to content

Conversation

@fwiesel
Copy link
Contributor

@fwiesel fwiesel commented Dec 16, 2025

Someone has to delete the Eviction eventually. Setting the OwnerReference will mean, if the Hypervisor gets deleted, so will the Eviction eventually.

@fwiesel fwiesel requested a review from notandy December 16, 2025 17:15
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/kvm-node-agent/internal/evacuation 20.69% (-1.53%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/kvm-node-agent/internal/evacuation/eviction.go 20.69% (-1.53%) 29 (+2) 6 23 (+2) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Someone has to delete the Eviction eventually. Setting the OwnerReference
will mean, if the Hypervisor gets deleted, so will the Eviction eventually.
@notandy notandy merged commit f7f362c into main Dec 16, 2025
6 checks passed
@notandy notandy deleted the eviction-owner-reference branch December 16, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants